This repository was archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
MOVED #93
Open
fritzo
wants to merge
56
commits into
forcedotcom:master
Choose a base branch
from
posterior:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MOVED #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindEigen3.cmake sets EIGEN3_INCLUDE_DIR not EIGEN3_INCLUDE_DIRs. This make CMakeLists.txt reference the correct variable. Also include the parent path `/eigen3/...` instead of the path found by FindEigen3.cmake so the `#include <eigen3/Eigen/*>` statements work.
So cmake can find libraries (e.g. eigen3) installed with conda.
Fixes inclusion of Eigen3
Fixes for Ubuntu 1604
The Travis build 60.2 complains
#error This file was generated by an older version of protoc which is
In file included from
/home/travis/build/posterior/distributions/src/io/schema.pb.cc:4:0:
#error This file was generated by an older version of protoc which is
incompatible with your Protocol Buffer headers.
- Adds protobuf as a dependency of `prepare_cc` in Makefile.
- Adds pyton-pil as a dependency, since python-scipy requires it for
scipy.misc.imread (used in examples/mixture/main.py:48)
https://docs.scipy.org/doc/scipy/reference/misc.html
- Adds protobuf-compiler as an apt dependency in .travis.yml.
- Adds python-pyflakes as an apt dependency in .travis.yml,
required for `make protobuf`.
- Removes ppa:cython-dev/master-ppa repository, since cython>=0.20.1 is
available in Ubuntu 14.04 (which the target platform of the Travis build).
- Adds pyflakes as a pip dependency before calling make, since `make protobuf`
requires pyflakes. Note that Ubuntu 14.04 does not have python-pyflakes in apt,
whereas Ubuntu 16.04 has python-pyflakes.
Not sure how this change is going to impact the installation from pip.
20171106 fsaad travis ubuntu1404
Fix numpy strict conversion error, (related to issue #15).
Update distributions to Python 3.
A few more Python 2->3 fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintainers have moved to https://github.com/posterior/distributions